Conversation
tony
force-pushed
the
rust
branch
2 times, most recently
from
January 31, 2026 22:50
ebc6a35 to
73262c1
Compare
why: allow libtmux tests to drive a rust-backed tmux_cmd without altering object APIs. what: - route tmux_cmd through vibe_tmux when LIBTMUX_BACKEND=rust - add LIBTMUX_RUST_CONNECTION_KIND for explicit bin/protocol selection - align raise_if_dead with rust backend exit semantics
why: Config-backed servers should start and load config without breaking liveness checks. what: - run first command with -f via tmux bin when server is down - align rust-backend server helpers to new signature - refine rust helper error handling and typing
why: We need per-test timing breakdowns to locate slow paths. what: - emit JSONL spans for libtmux rust backend calls - surface trace summary in pytest terminal output - capture server is_alive/require_server timing
why: Need per-command context when tracing slow rust backend calls. what: - include socket/config/connection_kind on rust_server_cmd span
why: Control-mode refresh hints should not trigger background view capture during tests. what: - Subscribe with capture_view=false for rust control-mode test server
why: Keep libtmux spans connected to vibe-tmux and propagate traceparent into Rust backend calls. what: - Add traceparent scope helper and current-span extraction fallback - Wrap rust backend calls with traceparent context in common/server paths
why: The rebase onto current master surfaced a missing contextlib import from conflict resolution, and the branch predated master's current lint/type gate (docstrings, typed otel shims, import ordering, line lengths). what: - Import contextlib in server.py for the otel fallback shim - Type the start_span/traceparent_scope fallback shims to match libtmux.otel's signatures and add docstrings - Annotate and reformat libtmux/otel.py; use contextlib.suppress - Add mypy overrides for optional opentelemetry/vibe_tmux imports - Keep the pytest plugin's dynamic _rust_refresh via setattr with a B010 suppression so mypy doesn't require a typed attribute - Apply ruff autofixes (import sort, nested with, formatting)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
Closes tmux-python/tmuxp#983